Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

when stream.stop doesnt exist, using stream.getVideoTracks and it stop all of them. #438

Merged
merged 1 commit into from
Jan 21, 2016

Conversation

antoniopol06
Copy link
Contributor

No description provided.

@ipeychev
Copy link
Contributor

Just started reviewing :)

:octocat: Sent from GH.

@ipeychev
Copy link
Contributor

Hey @antoniopol06,

Thanks for your PR!
We have a rule how to send and accept PR in this project - there should be an issue and for this issue one or more PR can be associated. In this issue we describe the problem, and provide solution. These issues then go to the release log when we release a new version. In this case there is a PR, but no issue and because I am out of context, I don't have an idea what is the problem, on which browser does that happen and why do we need this change.
In this case I created the [issue](Chrome deprecated MediaStream.stop%28%29 method #443), please keep that in mind for the next time.

@ipeychev ipeychev merged commit 1b7363c into liferay:master Jan 21, 2016
@ipeychev
Copy link
Contributor

Thank you, pull request merged! See changes here.

:octocat: Sent from GH.

@antoniopol06
Copy link
Contributor Author

Hi @ipeychev!

I wrote in the description that fixes #420 but you are right and the next time I will describe better the PR.

@ipeychev
Copy link
Contributor

Great! And thanks for the improvement!

@antoniopol06 antoniopol06 deleted the chrome_capture_image branch March 16, 2017 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants