ButtonKeystroke (#417, #141) #418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbalsas
changed the title
|
Iliyan, I've also pushed simple tests for some of the buttons. I'll try to start covering the rest whenever I have some time. |
|
Just started reviewing :) |
Sent from 
|
Thank you, pull request merged! See changes here. |
|
This is really cool, Chema! |
|
Also, the tests were passing on all IE browsers! |
|
💃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey @ipeychev, this adds the requested feature in #417. As a bonus, I've applied the mixin to the
bold,italicandunderlinebuttons to fix #141.I'm from home now, so I've only been able to verify that the tests pass on Chrome and Firefox...
What do you think?