chore: update CKEditor build to v4.14.1

[julien]

Due to: https://nvd.nist.gov/vuln/detail/CVE-2020-9281
(Previous attempt in #1396)

Closes: #1395

[wincent]

So, to help me review this, what is different in this compared to the original attempt (other than the obvious v4.14.0 to v4.14.1 change)? And how did you test it to know that it works?

[wincent]

I sent #1405 to salvage the bit of #1396 that is still relevant.

[julien]

There's nothing different from the previous attempt apart that this is using v4.14.1 instead of v4.14.0 of CKEditor.

To test it, I ran yarn build and yarn test (various times)

I also ran yarn start and checked the demo, edited the "demo page" by adding tables, making text bold, italic, added links, etc...

I then tested this "local" build inside my fork of liferay-portal - in the Blogs, Web Context and Site builder sections and everything is working as expected.

[wincent]

That sounds good enough to me!

[wincent]

Seeing as we still have that problem with yarn test not actually running all the tests, I also tested this using yarn test:debug in Firefox (because Chrome hangs).

Master:

This PR:

So FAILED count actually goes down by 1 on this PR, but PASSED goes down by 2; that's a very crude indication though because for the "PASSED" count I'm just counting lines that don't have the word "FAILED" in them 😬, and the log does print out other things...

Master:

Second run had the above errors, plus these:

That first one seems dependent on window size (seems to appear when I make the console too big).

This PR:

In short, a total shit-show. PR is unlikely to make things worse, may make them slightly better, so let's merge.

[julien]

I forgot about yarn test:debug, I'll give it a shot anyway to see if I can spot anything