Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update linting #1338

Merged
merged 6 commits into from
Oct 28, 2019
Merged

chore: update linting #1338

merged 6 commits into from
Oct 28, 2019

Conversation

wincent
Copy link
Contributor

@wincent wincent commented Oct 25, 2019

  • Updates linting dependencies and applies autofixes.
  • Maintains copyright headers with notice/notice plugin.
  • Lints previously unlinted files.

@wincent
fix: correct typo in code comment
1728827 
Noticed while scanning through:

#1338
@wincent
style: wrap long lines
78bf0b0
@wincent
fix: adjust copyright year
fd1ab16 
I originally had this as 2017 because I just copied the copyright.js
file from liferay-js-themes-toolkit. But going back now to adjust this
and make it match the year when the project started (ie. year of first
commit).
@julien
Copy link
Contributor

julien commented Oct 28, 2019

Just started reviewing :)

@julien julien merged commit af790a9 into master Oct 28, 2019
@wincent wincent deleted the wincent/lints branch October 28, 2019 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
2.0.x chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wincent @julien