feat: prepare to streamline releases with liferay-js-publish (#1334) #1335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test plan: Can't really be 100% sure this will work until we actually test it with a release. I did run `yarn version --minor` but stopped before actually publishing it. Closes: #1334
|
Just started reviewing :) |
julien
approved these changes
Oct 8, 2019
|
Corresponding changes to contributing page on wiki: https://github.com/liferay/alloy-editor/wiki/Contributing/_compare/3503723059ab81cde5fc4d24960821905acc74e1...84b9a9ddfeede478badc7446f88ff058b9243b41 |
|
We can't really test this without releasing, so we're just going to have to wait until the next release to be sure. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test plan: Can't really be 100% sure this will work until we actually test it with a release. I did run
yarn version --minorbut stopped before actually publishing it.Closes: #1334