Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update color for label #1270

Merged
merged 1 commit into from
May 20, 2019
Merged

fix: update color for label #1270

merged 1 commit into from
May 20, 2019

Conversation

julien
Copy link
Contributor

@julien julien commented May 20, 2019

Please see https://issues.liferay.com/browse/LPS-95292 for more information.

That also means I'll cut a release.

@julien julien requested a review from wincent May 20, 2019 10:52
@@ -37,6 +37,7 @@
}

label {
color: white;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we usually write this as #fff elsewhere?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes ... good catch

Please see https://issues.liferay.com/browse/LPS-95292 for more information.

That also means I'll cut a release.
@julien julien merged commit 1e1b01d into liferay:master May 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants