Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fix issues with video resizing and alignment #1246

Merged
merged 2 commits into from
Apr 24, 2019
Merged

fix: Fix issues with video resizing and alignment #1246

merged 2 commits into from
Apr 24, 2019

Conversation

julien
Copy link
Contributor

@julien julien commented Apr 24, 2019

No description provided.

fix: Fix issues with video resizing and alignment
2e8faf8 
Please see https://issues.liferay.com/browse/LPS-84167
Test plan:
Run `yarn build` from this branch and install in
a local liferay-portal with
`yarn add PATH_TO_WHERE_YOU_CLONED_ALLOY_EDITOR`
in the `modules/apps/frontend-editor/frontend-editor-alloyeditor-web`
OSGi module, then redeploy with `gradlew clean deploy`
wincent
wincent approved these changes Apr 24, 2019
View reviewed changes
Copy link
Contributor

@wincent wincent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This code is super opaque and brittle, but unless you feel like spending the next 12 weeks rewriting it, this is probably the right fix. 😱

@julien julien merged commit 6919e66 into liferay:master Apr 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wincent wincent wincent approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@julien @wincent