Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new string to src/assets/lang/language.json #1121

Merged
merged 3 commits into from
Feb 15, 2019
Merged

Add new string to src/assets/lang/language.json #1121

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
59ba511
Add new string to src/assets/lang/language.json
wincent Feb 15, 2019
be024cc
Look up default translations from "language.json", not "en.json"
wincent Feb 15, 2019
6e95c7f
Note the correct file to update to add new strings for translation
wincent Feb 15, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ With each major version release, new maintenance branches are created, and futur
* [lib/lang](https://github.com/liferay/alloy-editor/tree/master/lib/lang): language strings from upstream CKEditor project.
* [src/adapter/main.js](https://github.com/liferay/alloy-editor/tree/master/src/adapter/main.js): defines the top-level `AlloyEditor` API.
* [src/assets/lang](https://github.com/liferay/alloy-editor/tree/master/src/assets/lang): defines AlloyEditor-specific strings.
* [src/assets/lang/language.json](https://github.com/liferay/alloy-editor/tree/master/src/assets/lang/language.json): the canonical list of strings to be translated (via [Crowdin](https://crowdin.com)); add new strings here.
* [src/components](https://github.com/liferay/alloy-editor/tree/master/src/components): React components for buttons and toolbars.
* [src/__generated__/lang](https://github.com/liferay/alloy-editor/tree/master/src/__generated__/lang): language files generated by `npm run build:assets`, combining strings specific to AlloyEditor (defined in "src/assets/lang") and upstream strings from CKEditor (defined in "lib/lang"), available as `AlloyEditor.Strings`.
* [src/plugins](https://github.com/liferay/alloy-editor/tree/master/src/plugins): CKEditor plugins for resizing, aligning, and so on.
Expand Down
2 changes: 1 addition & 1 deletion scripts/build/gulp/tasks/languages.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ function buildLanguages(callback) {

const defaultTranslations = require(path.join(
Constants.langDir,
'en.json'
'language.json'
));

// Iterate over every existing lang file inside src/__generated__/lang
Expand Down
1 change: 1 addition & 0 deletions src/assets/lang/language.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@
"pasteVideoLink": "Paste Video Link",
"platformNotSupported": "Sorry, this platform is not supported",
"primary": "Primary",
"removeImage": "Remove Image",
"removeLink": "Remove link",
"rows": "Rows",
"success": "Success",
Expand Down