React UI update (#103, #104, #106, #107) #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just started reviewing :) |
Sent from …ons in toolbars. Fixes #106
|
Hey Iliyan, I pushed the new commit with the positioning fixes. I've done some refactors to the mixins to reuse as much code as possible. Let me know what you think! |
|
Hey Iliyan, I've pushed one more commit with the implementation of most of the buttons. After this, we're just missing the TwitterQuote (#109) and the behaviour change for the Link button (#108). I'll start working on those on monday, but I wanted to know if you like what's in here or if I should do any changes before going any further. Thanks! |
jbalsas
changed the title
|
Okay, Chema, great! I will process these for sure till Monday. Thanks 👍 |
|
Just started reviewing :) |
|
Thank you, pull request merged! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.