-
Notifications
You must be signed in to change notification settings - Fork 280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Toolbar doesn't close after hyperlinking an image #915
Comments
I'll create a PR shortly. |
jaclynong
added a commit
to jaclynong/alloy-editor
that referenced
this issue
Nov 19, 2018
jaclynong
added a commit
to jaclynong/alloy-editor
that referenced
this issue
Nov 19, 2018
julien
pushed a commit
that referenced
this issue
Nov 20, 2018
julien
added a commit
that referenced
this issue
Nov 20, 2018
Fixes #915 - Checks if selection data exists in linkSelectionTest
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Prelude
The issue described in #848 still exists for Chrome. I was not able to reproduce it in IE/Edge/Firefox.
The issue is that the linkSelectionTest does not check if the selectionData.element has any value (similar to what imageSelectionTest is checking).
Reproduce
<script src="alloy-editor/alloy-editor-all.js"></script>
buttons: ['imageLeft', 'imageCenter', 'imageRight', 'link']
Result :
On submission the toolbar isn't closed. However the toolbar closes when hyperlinking text.
Acceptance Criteria
The text was updated successfully, but these errors were encountered: