Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toolbar doesn't close after hyperlinking an image #915

Closed
jaclynong opened this issue Nov 17, 2018 · 1 comment
Closed

Toolbar doesn't close after hyperlinking an image #915

jaclynong opened this issue Nov 17, 2018 · 1 comment

Comments

@jaclynong
Copy link
Contributor

Prelude

The issue described in #848 still exists for Chrome. I was not able to reproduce it in IE/Edge/Firefox.

The issue is that the linkSelectionTest does not check if the selectionData.element has any value (similar to what imageSelectionTest is checking).

Reproduce

  1. Download AlloyEditor 1.5.15 source.
  2. Modify index.html to import the non-minified version of alloy-editor.
    <script src="alloy-editor/alloy-editor-all.js"></script>
  3. Modify alloy-editor-all.js to add 'link' button to image toolbar.
    buttons: ['imageLeft', 'imageCenter', 'imageRight', 'link']
  4. Open the editor with Chrome.
  5. Add an image or click the existing one.
  6. Add a hyperlink by either hitting Enter or clicking the check mark.

Result :
On submission the toolbar isn't closed. However the toolbar closes when hyperlinking text.

Acceptance Criteria

  1. Hyperlinking toolbar closes after submission.
  2. Test in Chrome, IE11, Edge, and FireFox.
@jaclynong
Copy link
Contributor Author

I'll create a PR shortly.

jaclynong added a commit to jaclynong/alloy-editor that referenced this issue Nov 19, 2018
jaclynong added a commit to jaclynong/alloy-editor that referenced this issue Nov 19, 2018
julien added a commit that referenced this issue Nov 20, 2018
Fixes #915 - Checks if selection data exists in linkSelectionTest
@julien julien added the 1.6.0 label Nov 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants