Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem with resizing images in Firefox #582

Closed
Bjarno opened this issue Aug 20, 2016 · 5 comments
Closed

Problem with resizing images in Firefox #582

Bjarno opened this issue Aug 20, 2016 · 5 comments
Labels
Milestone

Comments

@Bjarno
Copy link
Contributor

Bjarno commented Aug 20, 2016

The handles to resize an image are placed incorrectly when the image in centered...

example image (tried it with the web demo to make sure there was nothing wrong with my setup)

This appears on the latest version of Alloy Editor (1.2.3) on Mozilla Firefox. It doesn't happen at all on Google Chrome.

Another, possibly related, issue I have with images is that whenever you change the alignment, the resize handles aren't updated directly, only when clicking somewhere else and clicking again on the image.

There are no error messages in the console.

@Bjarno Bjarno changed the title Problem with resizing images Problem with resizing images in Firefox Aug 20, 2016
@ipeychev ipeychev added the bug label Aug 21, 2016
@ipeychev ipeychev added this to the 1.2.4 milestone Aug 21, 2016
@ipeychev
Copy link
Contributor

ipeychev commented Aug 21, 2016

Hello,

The problem is that AlloyEditor doesn't deal with image resizing in Firefox. This is it's native behavior. For WebKit browsers there is a plugin, but for Firefox and IE it is disabled, since they provide support for image resizing OOTB.

In case of Firefox, maybe they don't like the styles AlloyEditor applies to the image when it is being centered. Unfortunately, I'm not quite sure what other styles we could apply to make them happy and still to have image centering.

Thanks,

@Bjarno
Copy link
Contributor Author

Bjarno commented Aug 22, 2016

Any idea where I can disable Firefox behaviour and maybe try the webkit plugin? If at all possible?

@ipeychev
Copy link
Contributor

  1. There are threads about disabling img resizing, for example here.
  2. You will have to modify the checks, where this variable is used.

@Bjarno
Copy link
Contributor Author

Bjarno commented Aug 22, 2016

Disabling Firefox behaviour and also letting it check whether the browser is Firefox or not solved this for me. Without any side effects at first glance. May need more checks to make sure nothing else gets broken of course.

@ipeychev
Copy link
Contributor

Good! Then, would you like to send us a pull request? We may change the default behavior and use the plugin in Firefox too.

Thanks,

Bjarno added a commit to Bjarno/alloy-editor that referenced this issue Aug 23, 2016
Enables dragresize plug-in in Firefox and disables default browser behaviour.
ipeychev added a commit that referenced this issue Aug 23, 2016
ipeychev added a commit that referenced this issue Aug 23, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants