Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Core Table entity is not tested #250

Closed
jbalsas opened this issue Jun 19, 2015 · 2 comments
Closed

Core Table entity is not tested #250

jbalsas opened this issue Jun 19, 2015 · 2 comments
Labels
feature
Milestone
0.3.4

Comments

@jbalsas
Copy link
Contributor

jbalsas commented Jun 19, 2015

Our Table entity in core has no tests at this moment, so it's hard to confidently develop new features on top of it.

We should test everything properly before moving forward.
@ipeychev
Copy link
Contributor

+1
On Jun 19, 2015 7:51 AM, "Chema Balsas" [email protected] wrote:

Our Table entity in core has no tests at this moment, so it's hard to
confidently develop new features on top of it.

We should test everything properly before moving forward.

—
Reply to this email directly or view it on GitHub
#250.

@jbalsas
Copy link
Contributor Author

jbalsas commented Jun 19, 2015

I'm on it! 😉

ipeychev pushed a commit that referenced this issue Jun 22, 2015
@jbalsas @ipeychev
Add Table tests
ba7f5b9 
Fixes #250
ipeychev pushed a commit that referenced this issue Jun 22, 2015
@jbalsas @ipeychev
Fix create method for undefined params
4e0162b 
Fixes #250
ipeychev pushed a commit that referenced this issue Jun 22, 2015
@jbalsas @ipeychev
Fix wrong param. First param in CKEditor.dom.element.remove means pre…
ad7ef9c 
…serveChildren!

Fixes #250
ipeychev added a commit that referenced this issue Jun 22, 2015
@ipeychev
Add build files (auto-generated)
400b467 
Fixes #250
@ipeychev ipeychev added this to the 0.3.3 milestone Jun 22, 2015
ipeychev added a commit that referenced this issue Jun 22, 2015
@ipeychev
Add more table tests
a9bbae4 
Fixes #250
@ipeychev ipeychev modified the milestones: 0.3.4, 0.3.3 Jun 24, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
0.3.4
Development

No branches or pull requests
2 participants
@ipeychev @jbalsas