Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LPS-138431 Error Alloyeditor button-paragraph-align.jsx:56 Cannot read properties of undefined (reading 'icon') #1500

Closed
georgel-pop-lr opened this issue Sep 6, 2021 · 0 comments · Fixed by #1501

Comments

@georgel-pop-lr
Copy link
Member

georgel-pop-lr commented Sep 6, 2021

Description: If you add 'paragraphAlign' button to Alloy Editor Configurator and you add a paragraph text with an image inside, it will fail to open the menu. Check https://issues.liferay.com/browse/LPS-138431

Steps:

  1. Use 7.2.x bundle and on your portal-ext.properties add:
    editor.wysiwyg.default=alloyeditor
    editor.wysiwyg.portal-impl.portlet.ddm.text_html.ftl=alloyeditor

  2. Go to Content & Data -> Web content -> Select + Button -> add new Basic Web Content

  3. Select source code and add the content inside this file webcontent_sourcecode.txt

  4. Publish the web content and deploy the editor.configurator-1.0.0.jar

  5. Open again the web content created at step 2 and try to select a part of text 'This is not going to work' and you will see the error

Actual: Fails to open the menu, and you need to refresh page to continue working with the editor

Expected: Editor menu it should not fail when you select a text next to an image

Note: I used 7.2.x branch git hash d70471addc1516fba7cc4c58b999ee7d0dc02e95

@georgel-pop-lr georgel-pop-lr changed the title Error Alloyeditor button-paragraph-align.jsx:56 Cannot read properties of undefined (reading 'icon') LPS-138431 Error Alloyeditor button-paragraph-align.jsx:56 Cannot read properties of undefined (reading 'icon') Sep 6, 2021
georgel-pop-lr added a commit to georgel-pop-lr/alloy-editor that referenced this issue Sep 6, 2021
diegonvs added a commit that referenced this issue Sep 14, 2021
 fix: Prevent activeCommand in button-paragraph-align.jsx to be undefined (#1500)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant