LPD-50705 Fix failure in frontend-js-web/session.spec.ts test #4777
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…new user does not have English as default language.
…not be on an empty database, but it can be after a change in session.
|
CI is automatically triggering the following test suites:
|
|
ci:test:playwright |
izaera
reviewed
Mar 5, 2025
❌ ci:test:sf - 0 out of 1 jobs passed in 7 minutesClick here for more details.Base Branch:Branch Name: master Sender Branch:Branch Name: LPD-50493 1 Failed Jobs:For more details click here. [exec] > Task :packageRunCheckFormat
[exec] yarn run v1.13.0
[exec] \$ node-scripts check:ci
[exec]
[exec] ?????? Running preflight checks...
[exec]
[exec] ?????? Checking outdated tsconfig.json files ...
[exec]
[exec] ?????? Running TypeScript checks on modified files...
[exec] ?????? A total of 8 CPUs were detected: launching tsc using 8 workers
[exec]
[exec] ?????? Running format checks on modified files...
[exec]
[exec] Done in 12.43s.
[exec]
[exec] > Task :portalYarnCheckFormat
[exec] Gradle build finished at 2025-03-05 15:35:32.796.
[exec]
[exec] BUILD SUCCESSFUL in 26s
[exec] 3 actionable tasks: 3 executed
[exec]
[exec] See the profiling report at: file:///opt/dev/projects/github/liferay-portal/build/reports/profile/profile-2025-03-05-07-35-10.html
[exec] A fine-grained performance profile is available: use the --scan option.
[beanshell] Executing Gradle task: packageRunCheckFormat
[exec] To honour the JVM settings for this build a single-use Daemon process will be forked. For more on this, please refer to https://docs.gradle.org/8.5/userguide/gradle_daemon.html#sec:disabling_the_daemon in the Gradle documentation.
[exec] Daemon will be stopped at the end of the build
[exec] > Task :downloadNode
[exec]
[exec] > Task :npmInstall
[exec] npm WARN config production Use `--omit=dev` instead.
[exec]
[exec] added 130 packages, and audited 134 packages in 2s
[exec]
[exec] 23 packages are looking for funding
[exec] run `npm fund` for details
[exec]
[exec] found 0 vulnerabilities
[exec]
[exec] > Task :packageRunCheckFormat
[exec] npm WARN config production Use `--omit=dev` instead.
[exec]
[exec] > @liferay/[email protected] checkFormat
[exec] > tsc
[exec]
[exec] tests/export-import-web/instance.import.spec.ts(139,13): error TS2304: Cannot find name 'ObjectField'.
[exec] tests/export-import-web/instance.import.spec.ts(140,19): error TS2304: Cannot find name 'ObjectField'.
[exec] tests/layout-content-page-editor-web/formContainer.spec.ts(3525,16): error TS2304: Cannot find name 'ObjectField'.
[exec] tests/layout-content-page-editor-web/formContainer.spec.ts(3526,22): error TS2304: Cannot find name 'ObjectField'. |
|
Jenkins Build:test-portal-source-format#8516 Jenkins Report:jenkins-report.html Jenkins Suite:sf Pull Request:liferay-frontend#4777 Testray Routine:EE Pull Request Testray Build ID:Testray Importer:publish-testray-report#4894 |
liferay-continuous-integration
added
ci:test:playwright - failure
and removed
ci:test:playwright - pending
labels
|
Jenkins Build:test-portal-acceptance-pullrequest(master)#7485 Jenkins Report:jenkins-report.html Jenkins Suite:playwright Pull Request:liferay-frontend#4777 Testray Routine:EE Pull Request Testray Build:[master] ci:test:playwright - markocikos > liferay-frontend - PR#4777 - 2025-03-05[07:32:28] Testray Build ID:Testray Importer:publish-testray-report#16301 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
What is the goal of this PR?
The failure comes from different localization behaviors after login, for a user with different default language.
In current solution in master, it is assumed that (2) is the behavior always. In this PR, we handle both cases. Just (1) would probably be enough, but it could lead to local failures, or failures in interactions with future tests.