-
Notifications
You must be signed in to change notification settings - Fork 212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: Second opinion oracle test #857
Conversation
…nto feat/second-opinion-test
Hardhat Unit Tests Coverage Summary
Diff against master
Results for commit: 5888b1c Minimum allowed coverage is ♻️ This comment has been updated with latest results |
Seems that the reason for failed tests that PostTotalShares event is no longer emitted after LegacyOracle deprecation. |
9394071
to
5888b1c
Compare
|
||
const { chainId } = await ethers.provider.getNetwork(); | ||
// Sepolia-specific initialization | ||
if (chainId === 11155111n) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd move this to the protocol discovery since this may be used somewhere else, and here, take data from the context or move it under the protocol context flag to explicitly set tests state for Sepolia network.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Port of #211