Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: typos #817

Merged
merged 7 commits into from
Jan 22, 2024
Merged

Fix: typos #817

merged 7 commits into from
Jan 22, 2024

Conversation

vuittont60
Copy link
Contributor

fix: typos in test/
fix: typos in gasprofile/
fix: typos in contracts/
fix: typos in apps/node-operators-registry/
fix: typos in apps/lidooracle/
fix: typos in apps/lido/

@arwer13
Copy link
Contributor

arwer13 commented Jan 22, 2024

Thank you for the fixes, LGTM!

But please target develop branch, to follow the usual process: changes between on-chain releases go to develop first (and develop merged to master once the contracts are updated onchain).

⚠️ NB, there is a change in the contract deployed on-chain on mainnet (WithdrawalsManagerProxy). To keep correspondence between on-chain code and code in the repo in master branch we don't change contracts code. But this contract is an exception because it has been modified to support the scratch deployment. Thus I recon it is okay to change typos in it.

@TheDZhon TheDZhon changed the base branch from master to develop January 22, 2024 19:04
@TheDZhon TheDZhon self-requested a review January 22, 2024 19:26
Copy link
Contributor

@TheDZhon TheDZhon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thank you for your contribution!

@TheDZhon TheDZhon merged commit da5bc51 into lidofinance:develop Jan 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants