Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add forge tests for unstructured storage #774

Merged
merged 6 commits into from
Jun 8, 2023
Merged

Add forge tests for unstructured storage #774

merged 6 commits into from
Jun 8, 2023

Conversation

claudijd
Copy link
Contributor

@claudijd claudijd commented Jun 7, 2023 •
edited
Loading

This PR adds forge tests for UnstructuredStorage.sol

TheDZhon
TheDZhon reviewed Jun 7, 2023
View reviewed changes
Copy link
Contributor

@TheDZhon TheDZhon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks for going further and digging deeper 🙌

Please consider suggestions below if you have some time 🙏

@TheDZhon TheDZhon changed the base branch from master to develop June 7, 2023 12:47
@claudijd
Copy link
Contributor Author

claudijd commented Jun 7, 2023

@TheDZhon I incorporated all your suggestions, let me know if you have others.

TheDZhon
TheDZhon reviewed Jun 7, 2023
View reviewed changes
Copy link
Contributor

@TheDZhon TheDZhon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the significant deliverables 🍏

May I suggest something below if you still have some time and a strong attitude toward the case completeness 🙏

TheDZhon
TheDZhon approved these changes Jun 8, 2023
View reviewed changes
Copy link
Contributor

@TheDZhon TheDZhon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go! 🎸

Appreciate your enthusiasm 👍

@TheDZhon TheDZhon merged commit 24b9c85 into lidofinance:develop Jun 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheDZhon TheDZhon TheDZhon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@claudijd @TheDZhon