Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add check against underflow #772

Merged
merged 1 commit into from
Jun 7, 2023
Merged

Add check against underflow #772

merged 1 commit into from
Jun 7, 2023

Conversation

claudijd
Copy link
Contributor

This adds a simple check on AccountingOracleMock.sol to avoid it underflowing.

This is just the mock, so not live implementation risk here.

@claudijd claudijd changed the base branch from feature/shapella-upgrade to master June 1, 2023 15:25
@TheDZhon TheDZhon changed the base branch from master to develop June 7, 2023 11:41
TheDZhon
TheDZhon approved these changes Jun 7, 2023
View reviewed changes
Copy link
Contributor

@TheDZhon TheDZhon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, looks totally good 👍

FYI: I changed the base branch to reflect the usual workflow:
feature_branch → develop → master

@lidofinance lidofinance deleted a comment from meuamigopedro Jun 7, 2023
@TheDZhon TheDZhon merged commit 94b9ba2 into lidofinance:develop Jun 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheDZhon TheDZhon TheDZhon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@claudijd @TheDZhon