Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WQ: Replace _batches parameter with _lastIdToBeFinalized for finalize() #738

Merged

Conversation

folkyatina
Copy link
Member

No description provided.

@folkyatina folkyatina changed the base branch from fix/shapella-upgrade-from-rc1-to-rc2 to feature/erc4906 April 10, 2023 13:16
@TheDZhon TheDZhon mentioned this pull request Apr 10, 2023
16 tasks
Copy link
Contributor

@TheDZhon TheDZhon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TheDZhon
Copy link
Contributor

TheDZhon commented Apr 10, 2023

An alternative approach to consider: still passing _batches from Lido yet extracting the last element inside the public finalize method to pass it through the internal functions.

Base automatically changed from feature/erc4906 to fix/shapella-upgrade-from-rc1-to-rc2 April 12, 2023 17:30
@TheDZhon TheDZhon merged commit f84e796 into fix/shapella-upgrade-from-rc1-to-rc2 Apr 12, 2023
@TheDZhon TheDZhon deleted the refactor/finalize_params branch April 12, 2023 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants