Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: check nor active status #727

Merged
merged 4 commits into from
Apr 4, 2023
Merged

Fix: check nor active status #727

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
62d19d7
add active check to onlyNodeOperatorManager
loga4 Apr 3, 2023
68b57ba
fix tests
loga4 Apr 3, 2023
257b306
test: make nonce test more expressive
TheDZhon Apr 4, 2023
81745ff
chore: typos
TheDZhon Apr 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
chore: typos
  • Loading branch information
@TheDZhon
TheDZhon committed Apr 4, 2023
commit 81745ffb8317d84ed50da604aa7260e9670b2a17
4 changes: 2 additions & 2 deletions test/0.4.24/node-operators-registry.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2765,15 +2765,15 @@ contract('NodeOperatorsRegistry', (addresses) => {
}
})

it('nonce should not changed if operators are inactive', async () => {
it('nonce should not change if operators are inactive', async () => {
const [nodeOperatorBefore, keysOpIndexBefore, nonceBefore] = await Promise.all([
app.getNodeOperator(firstNodeOperatorId, false),
app.getKeysOpIndex(),
app.getNonce(),
])
assert.isTrue(nodeOperatorBefore.active)

// nonce is increased here
// nonce is increased only here
await app.deactivateNodeOperator(firstNodeOperatorId, { from: nodeOperatorsManager })

let [nodeOperatorAfter, keysOpIndexAfter, nonceAfter] = await Promise.all([
Expand Down