Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Abolish interface contracts #521

Merged
merged 13 commits into from
Feb 2, 2023

Conversation

arwer13
Copy link
Contributor

@arwer13 arwer13 commented Jan 31, 2023

No description provided.

@arwer13 arwer13 force-pushed the abolish-interface-contracts branch from 11207b9 to ef61159 Compare February 1, 2023 09:10
@arwer13 arwer13 marked this pull request as ready for review February 1, 2023 09:11
@arwer13 arwer13 requested review from loga4, TheDZhon and folkyatina and removed request for loga4 February 1, 2023 11:40
@folkyatina
Copy link
Member

What do you think about merge two IStakingModule to one in commons/interfaces? We already have IEIP712.sol there.

@arwer13
Copy link
Contributor Author

arwer13 commented Feb 1, 2023

@folkyatina

What do you think about merge two IStakingModule to one in commons/interfaces? We already have IEIP712.sol there.

The problem is that IStakingModule has bytes calldata _calldata arg in requestValidatorsKeysForDeposits what makes it compilable either in 0.4.24 or 0.8.9.
We cannot either make common interface and inherit it in 0.4.24 and 0.8.9 defining requestValidatorsKeysForDeposits with bytes _calldata and with bytes calldata _calldata respectively.

@folkyatina
Copy link
Member

@folkyatina

What do you think about merge two IStakingModule to one in commons/interfaces? We already have IEIP712.sol there.

The problem is that IStakingModule has bytes calldata _calldata arg in requestValidatorsKeysForDeposits what makes it compilable either in 0.4.24 or 0.8.9. We cannot either make common interface and inherit it in 0.4.24 and 0.8.9 defining requestValidatorsKeysForDeposits with bytes _calldata and with bytes calldata _calldata respectively.

In this case, I think, we should at least remove comments from 0.4.24, adding a notice about, where the docs can be found.

@arwer13 arwer13 merged commit e519e7b into feature/shapella-upgrade Feb 2, 2023
@arwer13 arwer13 deleted the abolish-interface-contracts branch February 2, 2023 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants