Feat: implement the ERC2612 (Permit) extension for StETH #486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheDZhon
force-pushed
the
feature/steth-permit
branch
from
0f443dc to
85ee91c
Compare
arwer13
reviewed
Jan 11, 2023
folkyatina
reviewed
Jan 12, 2023
There was a problem hiding this comment.
Isn't it better to move the whole IERC2612 implementation to the separate 0.8.9 subcontract. It will allow to use more OpenZeppelin code without any modification.
It will be more concise and clear, and substantially less code to review and less calls to external contract per permit.
Am I missing something?
arwer13
approved these changes
Jan 13, 2023
NB. No spec and tests yet.
TheDZhon
force-pushed
the
feature/steth-permit
branch
from
7e6ce20 to
4015478
Compare
|
@folkyatina please have a look and decide whether we can put forward this one to the trunk or polish it up 👍 |
folkyatina
approved these changes
Jan 16, 2023
| const digest = web3.utils.keccak256( | ||
| '0x1901' + | ||
| strip0x(domainSeparator) + | ||
| strip0x(web3.utils.keccak256(web3.eth.abi.encodeParameters(['bytes32', ...types], [typeHash, ...parameters]))) |
There was a problem hiding this comment.
Thinking about converging to using ethers.js library for Etherium everywhere in tests. Just a topic to think about, not a requirement.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #440.