Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove SafeERC20 logic from cstETH #209 #216

Merged
merged 2 commits into from
Dec 8, 2020
Merged

Remove SafeERC20 logic from cstETH #209 #216

merged 2 commits into from
Dec 8, 2020

Conversation

lxzrv
Copy link
Contributor

@lxzrv lxzrv commented Dec 1, 2020

Closes #209

@lxzrv lxzrv requested a review from ongrid December 1, 2020 16:44
@ongrid ongrid requested review from krogla, skozin and ongrid December 1, 2020 19:27
@ongrid
Copy link
Contributor

ongrid commented Dec 5, 2020

I noticed that Lido.sol stil continues using safeTransfer. https://github.com/lidofinance/lido-dao/blob/170e5d20d1117c1037f84ed16b5e1963c05da6e2/contracts/0.4.24/Lido.sol#L281

Then figured out that it was copied from Aragon that has safeERC20 baked in https://github.com/aragon/aragonOS/blob/07d309f5e81c768269dfc49373d41fac4528ebd2/contracts/common/VaultRecoverable.sol#L38

skozin
skozin approved these changes Dec 7, 2020
View reviewed changes
Copy link
Member

@skozin skozin left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMHO, just adding a comment that safeTransfer implementation comes from the library would be enough. But either way is fine, I don't have a strong opinion here.

@lxzrv lxzrv requested a review from skozin December 7, 2020 13:38
@ongrid ongrid self-requested a review December 7, 2020 14:42
@ongrid ongrid assigned skozin and unassigned lxzrv Dec 7, 2020
@ongrid
Copy link
Contributor

ongrid commented Dec 7, 2020

Agreed to assign @skozin to merge this

@skozin skozin changed the base branch from master to develop December 8, 2020 13:57
@skozin skozin merged commit 18858a1 into develop Dec 8, 2020
@skozin skozin deleted the QSP-13-fix branch December 8, 2020 14:01
dechjo pushed a commit to dechjo/lido-dao that referenced this pull request Jan 26, 2021
@skozin
Merge pull request lidofinance#216 from lidofinance/QSP-13-fix
922c155 
Remove SafeERC20 logic from cstETH lidofinance#209
@tamtamchik tamtamchik mentioned this pull request Nov 7, 2024
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krogla krogla krogla approved these changes

@ongrid ongrid ongrid approved these changes

@skozin skozin Awaiting requested review from skozin

Assignees

@skozin skozin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

QuantStamp Audit: QSP-13 Unclear use of safeTransferFrom. Remove use of safe wrapper.
4 participants
@lxzrv @ongrid @skozin @krogla