LIP-3 Oracle interface and reward algorithm for v0.2.x #153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skozin
reviewed
Nov 18, 2020
There was a problem hiding this comment.
The renaming will break the UI code in apps/*/app and https://github.com/lidofinance/widget, they should be updated, too, as a part of this.
|
Checked the rewards calculation and distribution part and it works as we want it. Can't really check the implementation or style so I'm not blocking from there. |
ongrid
added a commit
that referenced
this pull request
Nov 19, 2020
* epochsPerFrame * slotsPerEpoch * secondsPerSlot * genesisTime New semantics and default values are used in `deploy-lido-dao.js` which in turn called by `yarn run deploy:dao`. Reason: PR #153 review
skozin
requested changes
Nov 21, 2020
This was referenced Nov 21, 2020
skozin
approved these changes
Nov 22, 2020
ongrid
added a commit
that referenced
this pull request
Nov 22, 2020
* epochsPerFrame * slotsPerEpoch * secondsPerSlot * genesisTime New semantics and default values are used in `deploy-lido-dao.js` which in turn called by `yarn run deploy:dao`. Reason: PR #153 review
skozin
reviewed
Nov 22, 2020
ongrid
added a commit
that referenced
this pull request
Nov 22, 2020
* epochsPerFrame * slotsPerEpoch * secondsPerSlot * genesisTime New semantics and default values are used in `deploy-lido-dao.js` which in turn called by `yarn run deploy:dao`. Reason: PR #153 review
* New pushBeacon func now gets amount of validators visible on beacon * _getTransientBalance() - calculations based on number of validators * Amount of validators visible on beacon now come from the oracle. * Increment number of deposited validators (not sum balance) on deposit. * Reimplement getTotelControlledEther to getTotalPooledEther() #71 * RewardBase calculator and store removed from Lido scope * The rewards calculated in runtime in pushBeacon, no state modification * Remove epoch-awareness from Lido (Oracle still epoch-aware) * Rename remoteEther2 to beaconBalance #71 * Rename totalControlledEther to totalPooledEther * Rename getEther2Stat getBeaconStat Related: #110
* Title description * initialize() doxygen * fallback and submit, _submit * depositBufferedEther, _depositBufferedEther * setOracle * setDepositIterationLimit * pushBeacon * getBufferedEther * getTotalPooledEther * getToken * getOracle * setToken * setValidatorRegistrationContract * _setOperators * _setDepositIterationLimit * _ETH2Deposit, _stake, _submitted * distributeRewards * _getTransientBalance
* typo and confusion totalPooledEther vs newTotalPooledEther * rename totalControlledEther to totalPooledEther in comment
* epochsPerFrame * slotsPerEpoch * secondsPerSlot * genesisTime New semantics and default values are used in `deploy-lido-dao.js` which in turn called by `yarn run deploy:dao`. Reason: PR #153 review
|
rebased to fix |
skozin
reviewed
Nov 22, 2020
| t.is(await lidoHelper.getTotalControlledEther(), usersDeposits, 'Total controlled ether in Lido') | ||
| t.is(await ether2Stat.deposited, usersDeposits, 'Check that the ether2 stat is changed correctly') | ||
| t.is(await lidoHelper.getTotalPooledEther(), usersDeposits, 'Total pooled ether in Lido') | ||
| t.is(await ether2Stat.depositedValidators, usersDeposits, 'Check that the ether2 stat is changed correctly') |
There was a problem hiding this comment.
This is clearly broken since we're comparing the number of deposits with their amount, but let's fix E2E in a separate PR.
Closed
krogla
pushed a commit
that referenced
this pull request
Jan 26, 2021
* epochsPerFrame * slotsPerEpoch * secondsPerSlot * genesisTime New semantics and default values are used in `deploy-lido-dao.js` which in turn called by `yarn run deploy:dao`. Reason: PR #153 review
dechjo
pushed a commit
to dechjo/lido-dao
that referenced
this pull request
Jan 26, 2021
* epochsPerFrame * slotsPerEpoch * secondsPerSlot * genesisTime New semantics and default values are used in `deploy-lido-dao.js` which in turn called by `yarn run deploy:dao`. Reason: PR lidofinance#153 review
dechjo
pushed a commit
to dechjo/lido-dao
that referenced
this pull request
Jan 26, 2021
LIP-3 Oracle interface and reward algorithm for v0.2.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #110 - funds "in process" (from deposit submission until it gets processed and added to the beacon state's validators list) got treated like a decrease, the behavior was equal to slashing and lead to significant drops in stETH supply.
The new implementation counts the number of deposited validators as the funds get teposited on stake, so there is no time gap when funds are not accounted. Until the oracle can see the validator, it's assumed to have 32 ETH balance.
Spec: LIP-3
Note: full-cycle integration tests need to re-calculate and double-check all the numbers, made a separate task for this #152
closes #128
closes #129
closes #87
closes #4