Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No check for report in submitReportData #634

Closed
Tracked by #618
avsetsin opened this issue Feb 18, 2023 · 1 comment
Closed
Tracked by #618

No check for report in submitReportData #634

avsetsin opened this issue Feb 18, 2023 · 1 comment

Comments

@avsetsin
Copy link
Contributor

Two contracts have a similar problem: ValidatorExitBusOracle and AccountingOracle.

After the consensus phase of the report, the oracle daemon should deliver the data for which the consensus has been gathered by calling the submitReportData method. The method does not check if the data has been previously submitted, which might lead to repeated calls to this method by another or the same oracle daemon.

In the case of ValidatorExitBusOracle, this will lead to duplicate exit requests and incorrect accounting of the total number of requested validators to exit stored in TOTAL_REQUESTS_PROCESSED_POSITION.

In the case of AccountingOracle, in most cases such a scenario should lead to a transaction revert. However, if all operations performed in the report, such as withdrawal from Withdrawal and Execution Layer Rewards vaults, are possible to perform again, it can lead to a serious mismatch in the protocol state.

@TheDZhon
Copy link
Contributor

TheDZhon commented Feb 21, 2023

The fix is integrated into the latest Lido 2.0 beta2 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants