Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deposits fail when the Node Operator with id 0 is deactivated #227

Closed
skozin opened this issue Dec 4, 2020 · 1 comment · Fixed by #226
Closed

Deposits fail when the Node Operator with id 0 is deactivated #227

skozin opened this issue Dec 4, 2020 · 1 comment · Fixed by #226
Assignees
@skozin
Labels
bug Something isn't working solidity issues/tasks related to smart contract code

Comments

@skozin
Copy link
Member

skozin commented Dec 4, 2020 •
edited
Loading

Steps to reproduce:

  1. Add two Node Operators, add keys for each of them.
  2. Deactivate the operator with the index 0.
  3. Submit 32 Ether to the pool and try to make a deposit.

Expected result

The deposit tx succeeds, a key of the operator with the index 1 is used.

Actual result

The deposit tx reverts with the reason MATH_SUB_UNDERFLOW.

Failing test added in 9cceafa.
Fixed in 44626e2.
@skozin skozin added bug Something isn't working solidity issues/tasks related to smart contract code labels Dec 4, 2020
@skozin skozin self-assigned this Dec 4, 2020
skozin added a commit that referenced this issue Dec 4, 2020
@skozin
add a failing test for #227
9cceafa
skozin added a commit that referenced this issue Dec 4, 2020
@skozin
fix an index underflow (see the prev. commit for the test)
44626e2 
fixes #227
@skozin skozin mentioned this issue Dec 4, 2020
Merged
@skozin skozin changed the title Deposits fail when the Node Operator with id 0 is disabled Deposits fail when the Node Operator with id 0 is deactivated Dec 5, 2020
@ujenjt
Copy link
Member

ujenjt commented Dec 15, 2020

Fixed in #226

@ujenjt ujenjt closed this as completed Dec 15, 2020
dechjo pushed a commit to dechjo/lido-dao that referenced this issue Jan 26, 2021
@skozin
add a failing test for lidofinance#227
34d0eef
dechjo pushed a commit to dechjo/lido-dao that referenced this issue Jan 26, 2021
@skozin
fix an index underflow (see the prev. commit for the test)
4097f62 
fixes lidofinance#227
tamtamchik pushed a commit that referenced this issue Oct 11, 2024
@avsetsin
Merge pull request #227 from lidofinance/feat/sr-1.5-sc-oracle-upper-…
14904a6 
…limit

Update CL_BALANCE_ORACLES_ERROR_UPPER_BP_LIMIT
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@skozin skozin

Labels
bug Something isn't working solidity issues/tasks related to smart contract code
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Move signing keys selection to NodeOperatorsRegistry lidofinance/core
2 participants
@ujenjt @skozin