Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't obscure notation when refreshing on a phone #16820

Merged
merged 5 commits into from
Jan 21, 2025
Merged

Don't obscure notation when refreshing on a phone #16820

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
60ac59c
Fix a minor bug where the notation of the current move is sometimes o…
johndoknjas Jan 20, 2025
885bc05
Merge branch 'master' into fully-show-notation-on-refresh
johndoknjas Jan 20, 2025
95dbe52
Merge branch 'master' into fully-show-notation-on-refresh
johndoknjas Jan 21, 2025
9627a99
Merge branch 'master' into fully-show-notation-on-refresh
ornicar Jan 21, 2025
a5874f4
skip initial round moves scroll(s) on unplayed game page load
ornicar Jan 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion ui/round/src/view/replay.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -210,7 +210,13 @@ export function render(ctrl: RoundController): LooseVNode {
}
});
ctrl.autoScroll = () => autoScroll(el, ctrl);
ctrl.autoScroll();
if (ctrl.ply > 2) {
ctrl.autoScroll();
if (isCol1()) ctrl.autoScroll();
/* On a phone, the first `autoScroll()` sometimes doesn't fully show the current move. It's possible this
is due to some needed data not loading in time. The second `autoScroll()` fixes the issue, since the throttle
ensures a min wait of 100ms. */
}
}),
},
renderMoves(ctrl),
Expand Down
Loading