Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve font situation #16806

Merged
merged 5 commits into from
Jan 20, 2025
Merged

Conversation

schlawg
Copy link
Collaborator

@schlawg schlawg commented Jan 19, 2025

firefox 134 no longer likes the installed Noto Sans on fedora linux. it renders in italics. so fix that again, but really this time, and make some other improvements.

  • replace our noto sans and roboto woff2s with variable versions so we can render any weight from 100 to 900.
  • add a replace function to client build asset hashing - provide a filename along with a glob and it will update any globbed paths inside that file to the hashed urls
  • use that replace function to make a new font-face.css with correct asset urls, fixing the issue where some fonts preloaded by layout.scala were duplicated and ignored
  • minor font-weight edits in css because our Roboto is no longer Light.
  • remove local: 'Noto Sans'/'Roboto' rules from our @font-face blocks because we don't care about your shitty installed fonts. we only show the new hotness now.

this common/package.json bit triggers the font-face.css substitution:

"hash": {

@ornicar ornicar merged commit 7b0928d into lichess-org:master Jan 20, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants