Allow taking private notes in kid mode #16761
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ornicar
requested changes
Jan 12, 2025
| @@ -212,41 +212,40 @@ final class Round( | |||
| private[controllers] def getPlayerChat(game: GameModel, tour: Option[Tour])(using | |||
| ctx: Context | |||
| ): Fu[Option[Chat.GameOrEvent]] = | |||
| ctx.kid.no.so: | |||
There was a problem hiding this comment.
this causes the game chat to always be loaded and sent to all clients, including the mobile apps, where kids will get to see the other player messages.
There was a problem hiding this comment.
I feared my approach would be too simple.
Let me think of something else.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An idea to fix #16715
In the implementation, the note view is grouped with the discussion view
So, a quick fix is not to block the kid in the scala controller but in the snapdom part (view.ts)