Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add shaped window based on SDL_WINDOW_TRANSPARENT #66

Merged
merged 1 commit into from
Nov 23, 2023

Conversation

1bsyl
Copy link
Contributor

@1bsyl 1bsyl commented Mar 9, 2023

If Shaped Window get removed in SDL3,
this add back the functionality in SDL2-compat, but only for SDL_Renderer and for 1 window (which could be extended).

@1bsyl
Copy link
Contributor Author

1bsyl commented Mar 9, 2023

(testshape doesn't work perfectly, because there is one bug outside the scope)

@1bsyl
Copy link
Contributor Author

1bsyl commented Mar 9, 2023

the other issue is #67

@1bsyl 1bsyl force-pushed the br_removed_shaped_winow branch 2 times, most recently from 0067f97 to 9d83512 Compare March 14, 2023 11:05
@sezero sezero force-pushed the br_removed_shaped_winow branch from 9d83512 to 2a89e7f Compare November 23, 2023 02:25
@sezero
Copy link
Contributor

sezero commented Nov 23, 2023

@1bsyl, @slouken: I rebased this so that it applies cleanly. (Build-tested only, no run-testing!)

Either this, or some new implementation is needed after shaped window removal in SDL3.

@slouken
Copy link
Collaborator

slouken commented Nov 23, 2023

I have this covered, thanks!

@slouken slouken closed this Nov 23, 2023
@slouken slouken reopened this Nov 23, 2023
@slouken slouken merged commit 03631a8 into libsdl-org:main Nov 23, 2023
@sezero
Copy link
Contributor

sezero commented Nov 23, 2023

but only for SDL_Renderer and for 1 window (which could be extended).

Can these limitations be lifted?

I have this covered, thanks!

Something changed?

@slouken
Copy link
Collaborator

slouken commented Nov 23, 2023

Yes, the limitations can be lifted. I was working on something that did that, but I ended up deciding it was better to merge than leave it broken for a few days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants