Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed SDL_bool in favor of plain bool #10892

Merged
merged 2 commits into from
Sep 18, 2024
Merged

Removed SDL_bool in favor of plain bool #10892

merged 2 commits into from
Sep 18, 2024

Conversation

slouken
Copy link
Collaborator

@slouken slouken commented Sep 18, 2024

We require stdbool.h in the build environment, so we might as well use the plain bool type.

@slouken slouken force-pushed the bool branch 2 times, most recently from 929a7cd to 1db54fa Compare September 18, 2024 15:15
We require stdbool.h in the build environment, so we might as well use the plain bool type.

If your environment doesn't have stdbool.h, this simple replacement will suffice:
typedef signed char bool;
@slouken slouken requested a review from icculus September 18, 2024 15:19
@slouken slouken merged commit 95f7e53 into libsdl-org:main Sep 18, 2024
38 checks passed
@slouken slouken deleted the bool branch September 18, 2024 15:32
@hwsmm hwsmm mentioned this pull request Sep 21, 2024
@Iniquitatis
Copy link

I'm pretty sure I'm missing something here, but, AFAIK, stdbool.h was implemented in C99 along with the stdint.h. Why the latter isn't also used in SDL in this case?

@sezero
Copy link
Contributor

sezero commented Sep 21, 2024

I'm pretty sure I'm missing something here, but, AFAIK, stdbool.h was implemented in C99 along with the stdint.h. Why the latter isn't also used in SDL in this case?

#10894

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants