Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

winrt: Removed WinRT/Windows Phone/UWP support. #10731

Merged
merged 2 commits into from
Sep 6, 2024

Conversation

icculus
Copy link
Collaborator

@icculus icculus commented Sep 6, 2024

This nukes all the WinRT code and its project files, and pulls out all the multitude of #ifdef blocks that the WinRT code required.

This also cleans up a bunch of things that checked #if WIN32 || WINRT || GDK to just check SDL_PLATFORM_WINDOWS.

Fixes #10724.

@icculus icculus added this to the 3.0 ABI milestone Sep 6, 2024
Copy link
Contributor

@sezero sezero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

include/SDL3/SDL_system.h Outdated Show resolved Hide resolved
src/hidapi/SDL_hidapi.c Outdated Show resolved Hide resolved
@icculus
Copy link
Collaborator Author

icculus commented Sep 6, 2024

Okay, gonna let the builders finish just in case, then we can merge.

@icculus icculus merged commit ac08dde into libsdl-org:main Sep 6, 2024
38 checks passed
@icculus icculus deleted the sdl3-remove-uwp branch September 6, 2024 17:28
@icculus
Copy link
Collaborator Author

icculus commented Sep 6, 2024

SDL's UWP port has passed from this world. It has been cremated via Pull Request.

The family asks that you donate to a charity of your choice in lieu of flowers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove UWP support
3 participants