Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDL_shape.h: Non-namespaced enum #6897

Closed
circl-lastname opened this issue Dec 25, 2022 · 2 comments · Fixed by #8603
Closed

SDL_shape.h: Non-namespaced enum #6897

circl-lastname opened this issue Dec 25, 2022 · 2 comments · Fixed by #8603
Milestone

Comments

@circl-lastname
Copy link

circl-lastname commented Dec 25, 2022

The following is an enum in SDL_shape.h which does not respect the SDL_ prefix.

typedef enum {
    /** \brief The default mode, a binarized alpha cutoff of 1. */
    ShapeModeDefault,
    /** \brief A binarized alpha cutoff with a given integer value. */
    ShapeModeBinarizeAlpha,
    /** \brief A binarized alpha cutoff with a given integer value, but with the opposite comparison. */
    ShapeModeReverseBinarizeAlpha,
    /** \brief A color key is applied. */
    ShapeModeColorKey
} WindowShapeMode;

As long as the shape API is not removed, I believe this is a slight consistency issue.

This may be relevant to #6876 and #6569

@icculus icculus added this to the 3.2.0 milestone Dec 27, 2022
@icculus
Copy link
Collaborator

icculus commented Dec 27, 2022

I believe we're replacing this API, but I'm tossing this into the 3.2 milestone in case we don't.

@circl-lastname circl-lastname changed the title SDL_shape.h: Non-namespaced struct SDL_shape.h: Non-namespaced enum Dec 27, 2022
@circl-lastname
Copy link
Author

To close after #7316

slouken added a commit to slouken/SDL that referenced this issue Nov 22, 2023
slouken added a commit to slouken/SDL that referenced this issue Nov 22, 2023
slouken added a commit that referenced this issue Nov 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants