Adds Onn Remote support for menu navigation #864
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ready to be merged, brings support on board for Walmart's Onn 4k streamer Part No 100026240.
https://www.walmart.com/ip/onn-Android-TV-4K-UHD-Streaming-Device-with-Voice-Remote-Control-HDMI-Cable/636597403
Also to note - I had to flip the values for b and a from what the default Android TV cfg had, but it seems to be working fine now. Also reset my controllers configs just to make sure I had no active remaps happening on top of the default config.
What the values are now
Work in progress.. the D-Pad controls appear to work fine, but select and back appear to be non-functional at the moment. Creating this PR however for additional visibility to the problem. Also inclusion may still be warranted as partial support is better than no support and I have only tested it against a single Onn 4k streaming device, I believe there are others.I have confirmed though that button values appear to match the back button and select buttons, so I am not sure what the actual hang up is. May have to root the device later and do some more digging. Also not sure if adding the vendor and product id to the config file would help any or not, I have not yet pulled that info to add it, but it appears like it isn't needed for it to apply the config still.On another not I do feel like it is a mistake by the upstream retroarch repo to not push all of these controller configs into the user writable directory by default on Android vs expecting users to figure out where to go to reset the controller config directory.