sdl2: Add PS5 Controller note for L2/R2 #1142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added comments and a bug report link that L2/R2 have been manually edited due to a RetroArch bug.
RobLoach
changed the title
davidhedlund
added a commit
to davidhedlund/retroarch-joypad-autoconfig
that referenced
this pull request
Jul 19, 2024
Remove the analog trigger comments from the configuration file. The variables `input_l2_axis = "+4"` and `input_r2_axis = "+5"` were automatically generated by default, not manually added. It appears that the analog trigger issue (documented in RetroArch issue #6920) affects the UDEV and LINUXRAW controller drivers, but not the SDL2 driver. Given this new information, it would be advisable to revert your previous pull request (libretro#1142) which added a note about PS5 Controller L2/R2 triggers for the SDL2 driver.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added comments and a bug report link that L2/R2 have been manually edited due to a RetroArch bug.