Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve getopts and stderr message consistency in main #757

Merged

Conversation

roderickvd
Copy link
Member

There is no definitive standard on how to format getopts strings.
Usage of curly brackets seems best practice by these standards:

This is cosmetic only and was mostly extracted from #685.

There is no definitive standard on how to format getopts strings.
Usage of curly brackets seems best practice by these standards:
- http://www.tfug.org/helpdesk/general/man.html
- https://developers.google.com/style/code-syntax
@JasonLG1979
Copy link
Contributor

Not really an "options" issue but more of an unexpected missing arg. There is no --help to list all possible args. Granted if you try librespot --help it will complain with error: Unrecognized option: 'help' and then proceed to list all possible args. It would be nice if librespot had a proper help (-h, --help) It could be a separate PR but it seems like an oversight to not have a help.

@roderickvd
Copy link
Member Author

Here you go.

@roderickvd roderickvd merged commit 8774339 into librespot-org:dev May 26, 2021
@roderickvd roderickvd deleted the improve-getopts-and-stderr-consistency branch May 26, 2021 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants