Only remove callback when a tag handle was succesfully created. #433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timyhac
commented
Jan 25, 2025
src/libplctag/Tag.cs
Outdated
| var result = (Status)_native.plc_tag_destroy(nativeTagHandle); | ||
| ThrowIfStatusNotOk(result); | ||
| { | ||
| RemoveCallback(); |
There was a problem hiding this comment.
@kyle-github - this is the method that is used to tear down the tag either explicitly or implicitly by the garbage collector.
Previously, this code was checking that neither removing the event callback, nor destroying the tag, returned an error code, and if so would throw an exception. I'm not sure if there are any valid reasons for return an error code (other than bugs in the wrapper or core library), and I believe there is no recourse if either fail.
The new code fixes the bug that was there (found in #432) and also ignores any other errors that might occur.
Your thoughts?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.