Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump go-libp2p dependencies in pubsub test #7

Merged
merged 4 commits into from
May 20, 2020

Conversation

yusefnapora
Copy link
Contributor

This bumps us up to go-libp2p v0.9.0 for the pubsub test - I was getting a build error with 0.6.1 due to some api changes in swarm.

@yusefnapora
Copy link
Contributor Author

yusefnapora commented May 19, 2020

oh dear... with the updated deps I'm getting failures:

2020-05-19T16:32:23.759Z	ERROR	net/identify	identify/id.go:432	latest peer record does not exist. identify message incomplete!
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x8 pc=0x6dfb97]

goroutine 234 [running]:
github.com/libp2p/go-libp2p-core/record.(*Envelope).Marshal(0x0, 0xc0005b68e0, 0x8, 0x8, 0x203000, 0x2)
	/go/pkg/mod/github.com/libp2p/[email protected]/record/envelope.go:196 +0x37
github.com/libp2p/go-libp2p/p2p/protocol/identify.(*IDService).populateMessage(0xc0001f1040, 0xc0007780b0, 0xf83440, 0xc00048a720, 0xc000354380)
	/go/pkg/mod/github.com/libp2p/[email protected]/p2p/protocol/identify/id.go:469 +0x4ca
github.com/libp2p/go-libp2p/p2p/protocol/identify.(*IDService).sendIdentifyResp(0xc0001f1040, 0xf83f40, 0xc0003129c0)
	/go/pkg/mod/github.com/libp2p/[email protected]/p2p/protocol/identify/id.go:402 +0x39a
github.com/libp2p/go-libp2p/p2p/host/basic.(*BasicHost).SetStreamHandler.func1(0xc0001fe280, 0xe, 0x7f0c590e5198, 0xc0003129c0, 0x1, 0x0)
	/go/pkg/mod/github.com/libp2p/[email protected]/p2p/host/basic/basic_host.go:476 +0x9d
created by github.com/libp2p/go-libp2p/p2p/host/basic.(*BasicHost).newStreamHandler
	/go/pkg/mod/github.com/libp2p/[email protected]/p2p/host/basic/basic_host.go:327 +0x63c

😢

@yusefnapora
Copy link
Contributor Author

@raulk / @aarshkshah1992 have you guys seen any latest peer record does not exist errors with go-libp2p 0.9.0? Am I possibly missing a dependency somewhere?

@aarshkshah1992
Copy link

@yusefnapora This should now be fixed. Please can you close the issue if you are happy ?

libp2p/go-libp2p#943

@yusefnapora yusefnapora merged commit d5bdcb5 into master May 20, 2020
@yusefnapora yusefnapora deleted the fix/pubsub-dependencies branch May 20, 2020 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants