-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce composite action for running ping interop tests #123
Conversation
76be178
to
1640a96
Compare
@@ -12,3 +12,8 @@ jobs: | |||
uses: "./.github/workflows/run-testplans.yml" | |||
with: | |||
dir: "multidim-interop" | |||
run-multidim-interop-ng: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we just replace the above?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm guessing the intent was to make sure the existing flow didn't break?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, it is always easy enough to just remove the above later once we are fully migrated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good.
After we merge this, I'm guessing the plan is to change {rust,go}-libp2p to use this composite action at the current commit. Then we can rollout the other changes?
Yep, that would be the idea! |
I opened a PR for |
This PR implements some of the ideas discussed in #111. It is intended to be fully backwards-compatible and can thus be rolled out incrementally across our repositories.
We do a few things here:
test-plans
repository to access the action's source code. We can reuse this checkout to access the rest of the repository. Thus, if we reference this action via a commit hash, downstream repositories don't suddenly break on changes to the test-runner or other things in here.extra-versions
should be a space-separated list of JSON files that each contain a JSON object which describes a version to include in the matrix. See the changes to the JSON file in therust-libp2p
PR: https://github.com/libp2p/rust-libp2p/pull/3414/filesextra-version
in the test runner is backwards-compatible.containerImageID
exists locally. As you can see from therust-libp2p
PR, all that is needed is to build and tag the image locally. Because we are within the same workflow, the state of the local docker daemon is preserved.