feat(connections): clarify state management around supported protocols #530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mxinden
approved these changes
Mar 14, 2023
There was a problem hiding this comment.
Thank you @thomaseizinger for taking this from a rust-libp2p discussion to a libp2p/specs discussion to a libp2p/specs pull request and in the future to a rust-libp2p pull request.
Will leave some time for others to comment before merging.
Menduist
reviewed
Mar 14, 2023
| physical connection to a peer. It MAY only support a protocol based on properties | ||
| of a physical connection to e.g. limit the use of bandwidth-heavy protocols over | ||
| a relayed or metered connection. A libp2p node MAY offer different sets of protocols | ||
| to different peers. It MAY revoke or add the support for a protocol at any time, |
There was a problem hiding this comment.
Maybe say that when that happens, it should warn us with an identify push?
There was a problem hiding this comment.
I am not sure. This section of the specs is pretty ambivalent about protocols. Do we really want to introduce this here?
I like the idea but I think it would be better added to the identify spec rather than here.
marten-seemann
approved these changes
Mar 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #525.