Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gossipsub Protocol #898

Merged
merged 113 commits into from
Jan 24, 2020
Merged

Gossipsub Protocol #898

merged 113 commits into from
Jan 24, 2020

Conversation

AgeManning
Copy link
Contributor

@AgeManning AgeManning commented Jan 29, 2019 •
edited
Loading

This is an implementation of the gossipsub protocol as in the libp2p-specs.

This is feature-complete, except for the control-message piggy-backing and peer-tagging, which still need to be implemented.

Currently this implementation is not backwards compatible with floodsub nodes (see #880).

Further testing and debugging will be done over the next few weeks.

@jamesray1 jamesray1 mentioned this pull request Jan 31, 2019
Closed
twittner
twittner reviewed Feb 1, 2019
View reviewed changes
protocols/gossipsub/examples/chat.rs Outdated Show resolved Hide resolved
protocols/gossipsub/regen_structs_proto.sh Outdated Show resolved Hide resolved
protocols/gossipsub/Cargo.toml Outdated Show resolved Hide resolved
protocols/gossipsub/Cargo.toml Outdated Show resolved Hide resolved
protocols/gossipsub/rpc.proto Outdated Show resolved Hide resolved
protocols/gossipsub/src/layer.rs Outdated Show resolved Hide resolved
protocols/gossipsub/src/layer.rs Outdated Show resolved Hide resolved
protocols/gossipsub/src/mcache.rs Outdated Show resolved Hide resolved
protocols/gossipsub/src/layer.rs Outdated Show resolved Hide resolved
protocols/gossipsub/src/layer.rs Outdated Show resolved Hide resolved
@AgeManning
Create gossipsub crate - Basic template, borrowed from floodsub
e9b7059
@AgeManning
Add a GossipsubConfig struct and set up basic structures in the Gossi…
e09cb3f 
…psub struct
@AgeManning
Begin implementation of join. Adds get_random_peers helper function a…
65f3211 
…nd adds tests
@AgeManning
Implements gossipsub leave()
bcef5ff
@AgeManning
Update publishMany to incorporate gossipsub mesh and fanout logic
fb0160f
@AgeManning
Use the gossipsub mesh for determining peer subscription
e0933dd
@AgeManning
Remove subscribed_topics field from the Gossipsub struct
6de264e
@AgeManning
Rename gossipsubconfig to ProtocolConfig
e3c3d0f
@AgeManning
Implement the gossipsub control messages into the Codec's Encode/Deco…
47dbb69 
…de and modifies GossipsubRpc
@AgeManning
Modify GossipsubActions to enums for succinctness.
e05f363
@AgeManning
Modify the memcache to store Gossipsub messages
53c364b
@AgeManning
Implement control message handling.
cb5e20b
@AgeManning
Update control message handling to handle multiple messages.
e865ed5
@AgeManning
Handle received gossipsub messages using pre-built handlers.
80673d1
@AgeManning
Remove excess connected peer hashmap
1aa63ad
@AgeManning
Add extra peer mapping and consistent topic naming.
db345bb
@AgeManning
Implement heartbeat, emit_gossip and send_graft_prune.
5531342
@AgeManning
Group logic in forwarding messages. Add messages to memcache.
a29ae37
@AgeManning
Add heartbeat timer and move location of helper function.
a85ee9a
@AgeManning
Add gossipsub the libp2p workspace, makes layer structs public
e0142b6
@AgeManning
Add logging to gossipsub
8cdaf6b 
- Adds the log crate and implements logging macros
- Specifies versions for external crates
@AgeManning
Add example chat for debugging purposes
deccbe5
@AgeManning
Implement libp2p#868 for gossipsub.
e69a772
@AgeManning
Add rust documentation to gossipsub crate.
3dad3ea 
- Adds basic documentation, overview and examples to the gossipsub
crate.
@AgeManning
Re-introduce the initial heartbeat time config.
77047c3 
This commit also adds the inject_connected test.
@AgeManning
Add subscribe tests.
c7b3ca5 
- Modifies `handle_received_subscriptions` to take a reference of
subscriptions
- Adds `test_subscribe`
- Adds `test_handle_received_subscriptions`
- Adds tests for the filter in `get_random_peers`
@mxinden
Copy link
Member

mxinden commented Jan 15, 2020

Just updated sigp#22, sorry for the delay.

@AgeManning
Copy link
Contributor Author

Ok. Stable-futures and latest master have been merged in.

tomaka
tomaka reviewed Jan 23, 2020
View reviewed changes
Copy link
Member

@tomaka tomaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only gave a brief looked, and I'm tempted to trust @mxinden's review when it comes to the logic.

protocols/gossipsub/regen_structs_proto.sh Outdated Show resolved Hide resolved
protocols/gossipsub/src/config.rs Outdated Show resolved Hide resolved
protocols/gossipsub/src/protocol.rs Show resolved Hide resolved
@AgeManning
Copy link
Contributor Author

Applied @tomaka's suggestions and re-merged master.

@mxinden
Copy link
Member

mxinden commented Jan 24, 2020

I have another pull request following up on the inbound substream error handling discussion: sigp#24. I think the discussion is worth having. I don't think it should block this pull request.

mxinden
mxinden approved these changes Jan 24, 2020
View reviewed changes
Copy link
Member

@mxinden mxinden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only gave a brief looked, and I'm tempted to trust @mxinden's review when it comes to the logic.

I would interpret this as an approval @tomaka? Anyone else wanting to give this a review?

I have a couple of smaller comments left, but I think this is in a great merge-able state.

Thanks @AgeManning for all the hard work!

tomaka
tomaka approved these changes Jan 24, 2020
View reviewed changes
Copy link
Member

@tomaka tomaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 for merging! I haven't actually looked at the logic, but the general code organization and clean-ness looks code.

@tomaka
Copy link
Member

tomaka commented Jan 24, 2020

@AgeManning Are we good for merging this?

@AgeManning
Copy link
Contributor Author

Yep I think so. I've not updated the code base I'm using to stable futures yet, so haven't tested this version at any scale.
There may be a few more PRs to add things like message signing. But I think the current state is usable and fits better in the libp2p code base with proper versioning rather than the fork I'm maintaining.

If this sounds good to you guys, merge away :)

@tomaka tomaka merged commit 37c7d73 into libp2p:master Jan 24, 2020
@artemii235 artemii235 mentioned this pull request Mar 12, 2020
Closed
19 tasks
@thomaseizinger
Copy link
Contributor

There may be a few more PRs to add things like message signing.

Is there already an issue tracking this somewhere? I couldn't find anything but would be interested in following it's progress and to coordinate potential contributions :)

@AgeManning
Copy link
Contributor Author

@thomaseizinger
I am planning on building gossipsub 1.1. Ideally starting in a week. I can put the PR up to track if you like.
I'll add the message signing in as I go.

@AgeManning AgeManning deleted the gossipsub branch July 1, 2020 07:23
@mxinden mxinden mentioned this pull request Apr 1, 2021
Merged
@AgeManning AgeManning mentioned this pull request Dec 13, 2021
Closed
@AgeManning AgeManning mentioned this pull request Dec 15, 2022
Merged
4 tasks
@mxinden mxinden mentioned this pull request Feb 13, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@twittner twittner twittner left review comments

@mxinden mxinden mxinden approved these changes

@tomaka tomaka tomaka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@AgeManning @g-r-a-n-t @tomaka @mxinden @thomaseizinger @twittner @pawanjay176