Fix stack overflow when printing a SubstreamRef #599
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dvdplm
approved these changes
Nov 2, 2018
twittner
reviewed
Nov 2, 2018
core/src/nodes/node.rs
Outdated
| .field("listen_addr", listen_addr) | ||
| NodeEvent::InboundSubstream { .. } => { | ||
| f.debug_struct("NodeEvent::OutboundClosed") | ||
| .field("substream", &"...") |
There was a problem hiding this comment.
Would it not be useful to include the substream debug output here? After all, this was the primary motivation for adding the Debug impl for SubstreamRef IIRC.
twittner
reviewed
Nov 2, 2018
core/src/nodes/node.rs
Outdated
| where TTrans: Transport, | ||
| <TTrans::Listener as Stream>::Error: fmt::Debug, | ||
| impl<TMuxer, TUserData> fmt::Debug for NodeEvent<TMuxer, TUserData> | ||
| where |
There was a problem hiding this comment.
> git diff --check master
core/src/nodes/node.rs:350: trailing whitespace.
+where
There was a problem hiding this comment.
Our .editorconfig specifies trim_trailing_whitespace=true. I wonder why it is not picked up?
twittner
approved these changes
Nov 2, 2018
tomaka
added a commit
to tomaka/libp2p-rs
that referenced
this pull request
Nov 5, 2018
* Fix stack overflow when printing a SubstreamRef * Fix concern * More problems
dvdplm
added a commit
to dvdplm/rust-libp2p
that referenced
this pull request
Nov 6, 2018
…e-handled_node_tasks * upstream/master: Inject event by value in ProtocolsHandler (libp2p#605) Add a PeriodicPingHandler and a PingListenHandler (libp2p#574) Fix stack overflow when printing a SubstreamRef (libp2p#599) Add a peer id generator (libp2p#583) eg. -> e.g.; ie. -> i.e. via repren (libp2p#592)
dvdplm
added a commit
to dvdplm/rust-libp2p
that referenced
this pull request
Nov 6, 2018
…rs-to-vecdeque * upstream/master: Inject event by value in ProtocolsHandler (libp2p#605) Add a PeriodicPingHandler and a PingListenHandler (libp2p#574) Fix stack overflow when printing a SubstreamRef (libp2p#599) Add a peer id generator (libp2p#583) eg. -> e.g.; ie. -> i.e. via repren (libp2p#592)
dvdplm
added a commit
to dvdplm/rust-libp2p
that referenced
this pull request
Nov 7, 2018
…_swarm * upstream/master: Inject event by value in ProtocolsHandler (libp2p#605) Add a PeriodicPingHandler and a PingListenHandler (libp2p#574) Fix stack overflow when printing a SubstreamRef (libp2p#599) Add a peer id generator (libp2p#583) eg. -> e.g.; ie. -> i.e. via repren (libp2p#592)
dvdplm
added a commit
to dvdplm/rust-libp2p
that referenced
this pull request
Nov 9, 2018
…lection_stream * upstream/master: Use vecdeque for fair polling (libp2p#610) Add back the Swarm (libp2p#613) Remove dependency on tokio_current_thread (libp2p#606) Use chashmap from crates (libp2p#615) Fix grammar in core/nodes etc. (libp2p#608) Inject event by value in ProtocolsHandler (libp2p#605) Add a PeriodicPingHandler and a PingListenHandler (libp2p#574) Fix stack overflow when printing a SubstreamRef (libp2p#599) Add a peer id generator (libp2p#583) eg. -> e.g.; ie. -> i.e. via repren (libp2p#592) Add a IdentifyTransport (libp2p#569) Tests for HandledNode (libp2p#546) Some minor fixes reported by clippy (libp2p#600) Add a PeriodicIdentification protocol handler (libp2p#579) Add ProtocolsHandler trait (libp2p#573) Use paritytech/rust-secp256k1 (libp2p#598) Use websocket 0.21.0 (libp2p#597) Reexport multihash from the facade (libp2p#587) Add substrate to the list of projects using libp2p (libp2p#595) Remove spaces before semicolons (libp2p#591)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Does the same as #562 but the way I imagined it.