-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(kad): rename to follow naming convention across repository #4547
Conversation
I am wondering if non exported variable names from other files like |
We should rename the internal ones too but we don't have to add type-aliases for those :) |
Have a look at the CI failures. I think the type-aliases will have to go to the top-level module to be publicly visible :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great, thank you! To finish this off, can you please:
- Bump the patch version in
protocols/kad/Cargo.toml
- Make the same bump in
[workspace.dependencies]
inCargo.toml
- Write a changelog entry in
protocols/kad/CHANGELOG.md
Done! Thanks for the guidance! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Approvals have been dismissed because the PR was updated after the send-it
label was applied.
This pull request has merge conflicts. Could you please resolve them @PanGan21? 🙏 |
Description
Renamed the following
kad::Kademlia
->kad::Behaviour
kad::KademliaEvent
->kad::Event
kad::KademliaBucketInserts
->kad::BucketInserts
kad::KademliaStoreInserts
->kad::StoreInserts
kad::KademliaConfig
->kad::Config
kad::KademliaCaching
->kad::Caching
kad::KademliaEvent
->kad::Event
kad::KademliaConnectionType
->kad::ConnectionType
KademliaHandler
->Handler
KademliaHandlerEvent
->HandlerEvent
KademliaProtocolConfig
->ProtocolConfig
KademliaHandlerIn
->HandlerIn
KademliaRequestId
->RequestId
KademliaHandlerQueryErr
->HandlerQueryErr
Resolves: #4485
Notes & open questions
Change checklist