transports/tcp: only translate tcp addresses #2970
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
thomaseizinger
approved these changes
Oct 4, 2022
Comment on lines
+1271
to
+1273
| let tcp_listen_addr = Multiaddr::empty() | ||
| .with(Protocol::Ip4(Ipv4Addr::new(127, 0, 0, 1))) | ||
| .with(Protocol::Tcp(port)); |
There was a problem hiding this comment.
I always find these easier to read if we parse them from a string.
There was a problem hiding this comment.
I prefer using types where possible, avoiding any unwraps that would be needed when parsing from string :)
Co-authored-by: Thomas Eizinger <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Return
Nonein in<GenTcpTransport as Transport>::address_translationif the address is not a tcp address.Relevant if in case of something like
OrTransport<TcpTransport, QuicTransport>, where tcp would currently perform the address translation for quic addresses.Raise by @mxinden for quic in #2289 (comment), so I think the same should also be applied for the tcp transport.
Change checklist