-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
protocols/kad: Support multiple protocol names #2846
protocols/kad: Support multiple protocol names #2846
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @dmitry-markin for the patch!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me. Thanks @dmitry-markin for the follow-ups.
Would you do me a favor and prepare a pull request that removes the deprecated methods. This pull request we can merge once libp2p-kad
v0.40.0
was released, thus removing the deprecated methods with libp2p-kad
v0.41.0
.
Sure, can do this. @mxinden, meanwhile, could you merge this PR — GitHub says "Only those with write access to this repository can merge pull requests." |
@dmitry-markin do you need a new release soonish, or is depending on |
@mxinden substrate consumes libp2p from crates.io, so having the changes released would be great. Nevertheless, it's not something super urgent. |
A follow-up PR that removes the deprecated methods: #2866. |
Description
Add support for multiple Kademlia protocol names to allow protocol name upgrades.
Links to any relevant issues
Resolves #2837.
Change checklist