-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make the number of events buffered to/from tasks configurable #1574
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romanb
reviewed
May 14, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left only naming and documentation suggestions that are motivated as follows:
- Internally, I previously established the terminology of "task events" vs "task commands", rather than speaking of "events from" or "events to" tasks, respectively, so that naming in the pool and manager settings would be more consistent.
- On the public API, I don't think it is beneficial to talk about (background) tasks. Instead, a user of
libp2p-core
knows thatnotify_handler
is used to send events to the connection handlers and that he receives connection events by polling the network. Hence buffer sizes that relate tonotify_handler
and "connection events" are directly meaningful, especially with the added documentation about the effect of a full buffer.
Co-authored-by: Roman Borschel <[email protected]>
romanb
approved these changes
May 14, 2020
Co-authored-by: Roman Borschel <[email protected]>
mxinden
approved these changes
May 15, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For what my review is worth, this looks good to me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc paritytech/substrate#6009
Hints seem to indicate that we have some CPU issues in Substrate from the low number of events that can be buffered. This PR makes this limit configurable.
Additionally, this PR increases these values: the channel size from tasks to the swarm is now 32 (instead of 1!), and the channel size from the swarm to each task is now 7 (so 8 in practice).
When reviewing, keep in mind that channels reserve an extra element for each active sender, as documented: https://docs.rs/futures/0.3.5/futures/channel/mpsc/fn.channel.html
(I also slightly fixed the CHANGELOG to be alphabetically-ordered)