Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow configuration of outbound substream in OneShotHandler #1521

Merged
merged 2 commits into from
Apr 1, 2020
Merged

Allow configuration of outbound substream in OneShotHandler #1521

merged 2 commits into from
Apr 1, 2020

Conversation

sireliah
Copy link
Contributor

@sireliah sireliah commented Mar 25, 2020 •
edited
Loading

When opening a new outbound substream in OneShotHandler, you should be able to specify the timeout for the substream.

Follow up of discussion here: #1512

Do you like this solution or do you prefer the .with_substream_timeout(timeout) way?

@sireliah sireliah mentioned this pull request Mar 25, 2020
Closed
@sireliah sireliah force-pushed the oneshot-substream-timeout branch from c2d649e to c2e9397 Compare March 25, 2020 19:42
tomaka
tomaka suggested changes Mar 26, 2020
View reviewed changes
@sireliah sireliah force-pushed the oneshot-substream-timeout branch 2 times, most recently from ff3c88c to 80ac068 Compare March 26, 2020 22:16
@sireliah sireliah requested a review from tomaka March 28, 2020 16:33
tomaka
tomaka approved these changes Mar 30, 2020
View reviewed changes
Copy link
Member

@tomaka tomaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of nits

@sireliah sireliah force-pushed the oneshot-substream-timeout branch from 80ac068 to 93f08c7 Compare March 30, 2020 18:52
@sireliah sireliah requested a review from tomaka March 30, 2020 21:41
@tomaka tomaka merged commit 6b4bdc1 into libp2p:master Apr 1, 2020
@romanb
Copy link
Contributor

romanb commented Apr 1, 2020

I may be blind, but how does one now actually configure a OneShotHandlerConfig? I only see private fields and a Default impl.

@romanb
Copy link
Contributor

romanb commented Apr 1, 2020

Moreover, the one_shot is a private module and OneShotHandlerConfig is not re-exported by protocols_handler, which only leaves OneShotHandler::default() usable, since OneShotHandler::new requires a OneShotHandlerConfig. I'm a bit puzzled.

@romanb romanb mentioned this pull request Apr 1, 2020
Merged
@sireliah sireliah deleted the oneshot-substream-timeout branch April 1, 2020 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomaka tomaka Awaiting requested review from tomaka

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sireliah @romanb @tomaka