Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a NodeStream::shutdown method that shuts down the muxer in a clean way #551

Closed
tomaka opened this issue Oct 10, 2018 · 0 comments
Closed

Add a NodeStream::shutdown method that shuts down the muxer in a clean way #551

tomaka opened this issue Oct 10, 2018 · 0 comments
Labels
difficulty:moderate priority:nicetohave

Comments

@tomaka
Copy link
Member

tomaka commented Oct 10, 2018

No description provided.

twittner added a commit to twittner/rust-libp2p that referenced this issue Oct 11, 2018
@twittner
Add shutdown functionality to NodeStream.
bc08471 
The former allows triggering the shutdown process, whereas as the
latter drives any potential shutdown to completion.

Fixes libp2p#551.
twittner added a commit to twittner/rust-libp2p that referenced this issue Oct 11, 2018
@twittner
Add shutdown functionality to NodeStream.
dbbbe7e 
Add `NodeStream::shutdown` to allow triggering the shutdown process,
and `NodeStream::poll_shutdown` as the internal way to drive any
potential shutdown to completion.

Also shutdown the `NodeStream` in `Node::shutdown`.

Fixes libp2p#551.
@twittner twittner mentioned this issue Oct 11, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
difficulty:moderate priority:nicetohave
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tomaka