Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement std::error::Error for InboundFailure and OutboundFailure of request-response? #2017

Closed
thomaseizinger opened this issue Mar 26, 2021 · 1 comment · Fixed by #2033
Closed

Implement std::error::Error for InboundFailure and OutboundFailure of request-response? #2017

thomaseizinger opened this issue Mar 26, 2021 · 1 comment · Fixed by #2033

Comments

@thomaseizinger
Copy link
Contributor

It would be nice if these two types would implement std::error::Error and thereby Display. I am finding myself wanting to consolidate them using anyhow but that doesn't work at the moment.
@mxinden
Copy link
Member

mxinden commented Mar 30, 2021

I don't have an opinion on std::error::Error. I though we discussed this in the past but I might be mistaken, at least I can't find a past discussion on this.

@thomaseizinger do you want to prepare a patch?

thomaseizinger added a commit to thomaseizinger/rust-libp2p that referenced this issue Apr 7, 2021
@thomaseizinger
Implement std::error::Error for InboundFailure and OutboundFailure
b55ef85 
Fixes libp2p#2017.
thomaseizinger added a commit to thomaseizinger/rust-libp2p that referenced this issue Apr 7, 2021
@thomaseizinger
Implement std::error::Error for InboundFailure and OutboundFailure
2b8ff0b 
Fixes libp2p#2017.
@thomaseizinger thomaseizinger mentioned this issue Apr 7, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Implement std::error::Error for InboundFailure and OutboundFailure thomaseizinger/rust-libp2p
2 participants
@thomaseizinger @mxinden