Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Gossip simulator module #269

Merged
merged 36 commits into from
Feb 24, 2023
Merged

Add Gossip simulator module #269

merged 36 commits into from
Feb 24, 2023

Conversation

Nashatyrev
Copy link
Collaborator

@Nashatyrev Nashatyrev commented Feb 21, 2023 •
edited
Loading

Add Gossip simulator module.

  • Extract libp2p.testFixtures schedulers package to a dedicated :tools:schedulers module
  • Add :tools:simulator module
  • Simulation main classes are located in the package io.libp2p.simulate.main
  • Any simulation could be run from the gradle command line (gradle application plugin applied in the module)
  • Simulations are configured programmatically only
  • Add simulator README and the reference from the main README

@Nashatyrev
Move schedulers to a separate module
82a519d
@Nashatyrev
Add simulator module
a44f53b
@Nashatyrev
Remove obsolete classes
d50f817
@Nashatyrev
Sort unit tests
fdf2269
@Nashatyrev
Subscribe peers to topics in GossipSimulation instead of GossipSimPee…
654060e 
…r.start() to have all message handlers in place when message exchange starts
@Nashatyrev
Minor Network interface clean up
20b3083
@Nashatyrev
BlobDecouplingSimulation minor clean up
0f4282c
@Nashatyrev
Remove HostSimPeer, WireSimPeer and their accompanying classes: they …
2a59318 
…were draft and are not functional at the moment
@Nashatyrev
Refactor Simulation2 to GossipScoreTestSimulation
163d260
@Nashatyrev
Get rid of StreamSimPeer.currentTime default value for fast fail
2d9c734
@Nashatyrev
Minor clean up
2f31ada
@Nashatyrev
Add ConnectionsMessageCollector.clear() function
8ca97d3
@Nashatyrev
Field rename
4b2e02b
@Nashatyrev
Rename property
5402940
@Nashatyrev
Get rid of GlobalNetworkStatsCollector in favor of GossipMessageColle…
6c90ac8 
…ctor
@Nashatyrev
Add Slf4j binding runtime dependency for simulator
da20dce
@Nashatyrev
Move Simulation1 to sources
369ec5d
@Nashatyrev
Lint
b61cc94
@Nashatyrev
Add SimpleSimulation and integration test. Clean up other tests
984e13c
@Nashatyrev
Add ability to run simulations from gradle CLI
529262a
@Nashatyrev
Add simulator README.md
8ce24ed
@Nashatyrev
Rename the gradle application placeholder
c19c1df
@Nashatyrev
Add simulator README reference from the main README
919af60
@Nashatyrev
Minor README wording fix
6f8d76b
zilm13
zilm13 approved these changes Feb 21, 2023
View reviewed changes
Copy link
Contributor

@zilm13 zilm13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Do I understand correctly, that schedulers were not referenced from anywhere inside module before?

tools/simulator/README.md
> gradle :tools:simulator:run -PmainClass=<your.main.Class> [--args="you args"]
```

For example to run the sample simulation use the command below:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simple simulation?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sample simple simulation :)

@Nashatyrev
Copy link
Collaborator Author

Do I understand correctly, that schedulers were not referenced from anywhere inside module before?

Schedulers were used by tests and JMH benchmark. Now also used by the simulator

@zilm13
Copy link
Contributor

zilm13 commented Feb 21, 2023

Do I understand correctly, that schedulers were not referenced from anywhere inside module before?

Schedulers were used by tests and JMH benchmark. Now also used by the simulator

Ah.. I've finally found test using it. It's not broken, I see

@Nashatyrev
Copy link
Collaborator Author

I've added a number of changes: reactoring and cleaning up the simulator code only.
@zilm13 please let me know if I'm still good to go with these changes

@Nashatyrev Nashatyrev merged commit 70f712b into libp2p:develop Feb 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zilm13 zilm13 zilm13 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Nashatyrev @zilm13